Merge test workflow #115
Merged
Merge test workflow #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abubakkar2024
commented
Apr 12, 2024
abubakkar2024
commented
- conftest.py added to run tests under certain conditions when to skip and continue running them. All tests fail when unable to collect imports and milvus not enabled at specified port, hence conf code file assists in skipping them when the substring occur in the test code. ( milvus exception)
- Added a github actions workflow to run pytests on merge
parkererickson-tg
requested changes
Apr 12, 2024
will make the changes |
…to see whats happening
parkererickson-tg
approved these changes
May 9, 2024
app/metrics/tg_proxy.py
Outdated
There was a problem hiding this comment.
Is this rebased with main?
There was a problem hiding this comment.
Is this rebased?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.